Skip to content

fix(e2e): bump fee_settings test fees past the captured baseline#23087

Closed
AztecBot wants to merge 1 commit into
merge-train/fairiesfrom
claudebox/fix-merge-train-fairies-23048
Closed

fix(e2e): bump fee_settings test fees past the captured baseline#23087
AztecBot wants to merge 1 commit into
merge-train/fairiesfrom
claudebox/fix-merge-train-fairies-23048

Conversation

@AztecBot

@AztecBot AztecBot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the e2e_fees fee_settings > handles min fee spikes with default padding failure in the merge-train/fairies CI run after PR #23048 was merged (log).

The test captures stableMinFees right after TestContract is deployed (a local peak in feePerL2Gas), then proves two txs (slow), then calls bumpL2Fees(). By the time bumpL2Fees() runs, the chain's min fees have decayed below stableMinFees. A single 20% proving-cost bump only adds ~5% to total feePerL2Gas, which is not enough to climb back above the captured peak — so expect(stableMinFees < bumpedMinFees) fails.

bumpL2Fees now accepts an optional minTarget and bumps proving cost in a loop (each iteration waits for the bump to take effect via the existing retryUntil) until the chain's current min fees exceed the target. Both tests pass their baseline so the comparison is robust to decay. The padded-fee bound is target.mul(1 + DEFAULT_MIN_FEE_PADDING) (= target * 6), so there is plenty of headroom on the upper side.

PR #23048 itself is a pxe tagging refactor and doesn't touch fees — this is a pre-existing flake in the test that surfaced under this run's timing. The same approach was previously prepared in #22583, which was auto-closed only because it went stale.

Notes

ClaudeBox log: https://claudebox.work/s/c40fed098084dd7b?run=2

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 8, 2026
@AztecBot

AztecBot commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/01417062b958b715�01417062b958b7158;;�): yarn-project/scripts/run_test.sh prover-client/src/proving_broker/proving_broker.test.ts (14s) (code: 0)

@AztecBot

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant